Refactor builtin's execute method for wider return types #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, builtin's execute method was limited to ConstantValue. This meant that builtins could only return booleans, numbers or strings. It wasn't possible to return lists. This was an undue limitation on the possibilities of builtins. This refactors the return type of execute to the more general MarkIntermediateResult. This should allow to return ListValue for further processing.
oxisto
reviewed
Jul 27, 2021
src/main/java/de/fraunhofer/aisec/codyze/analysis/markevaluation/ExpressionEvaluator.java
Show resolved
Hide resolved
oxisto
approved these changes
Jul 27, 2021
src/main/java/de/fraunhofer/aisec/codyze/analysis/markevaluation/ExpressionEvaluator.java
Outdated
Show resolved
Hide resolved
src/main/java/de/fraunhofer/aisec/codyze/analysis/markevaluation/ExpressionEvaluator.java
Outdated
Show resolved
Hide resolved
…on/ExpressionEvaluator.java
…on/ExpressionEvaluator.java
|
Kudos, SonarCloud Quality Gate passed! |
fwendland
added a commit
that referenced
this pull request
Apr 15, 2024
* Refactor builtin's execute method for wider return types Previously, builtin's execute method was limited to ConstantValue. This meant that builtins could only return booleans, numbers or strings. It wasn't possible to return lists. This was an undue limitation on the possibilities of builtins. This refactors the return type of execute to the more general MarkIntermediateResult. This should allow to return ListValue for further processing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, builtin's execute method was limited to ConstantValue. This meant that builtins could only return booleans, numbers or strings. It wasn't possible to return lists. This was an undue limitation on the possibilities of builtins.
This refactors the return type of execute to the more general MarkIntermediateResult. This should allow to return ListValue for further processing.