Typestate cleanup and improvements #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxisto
force-pushed
the
typestate-improvements
branch
from
c02778a
to
e7afe1b
Compare
oxisto
changed the title
|
Kudos, SonarCloud Quality Gate passed! |
fwendland
added a commit
that referenced
this pull request
Apr 15, 2024
* Typescript cleanup and improvements * ++ * Last commit before getting rid of Stmt * Directly using CPG node as WPDS control location instead of additional class * Trying to reduce complexity * Reducing code smells * ++ * Smore cleanup Co-authored-by: fwendland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted
TypestateAnalysisto Kotlin code. In this process, I also removed the necessity to have yet another wrapper around Node. This removes theStmtclass, that was purely a wrapper around gremlin vertices and is now obsolete. Instead, we directly use theNodeas the WPDS control location.