Skip to content

Commit

Permalink
Merge pull request #87 from pfitzseb/sp/julia-1.0
Browse files Browse the repository at this point in the history
Fix deprecation warnings
  • Loading branch information
MikeInnes committed Aug 7, 2018
2 parents bd70d73 + a7d2b52 commit 18448ba
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion src/MacroTools.jl
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
__precompile__(true)

This comment has been minimized.

Copy link
@mdashti

mdashti Aug 15, 2018

@MikeInnes Is this done on purpose? Why is that? This change is breaking the precompilable projects that depend on MacroTools (e.g., SimpleTraits, LightGraphs, etc).

This comment has been minimized.

Copy link
@cstjean

cstjean Aug 15, 2018

Collaborator

Presumably it's for 1.0 compatibility, but REQUIRE is still at 0.6. Maybe it should be increased?

This comment has been minimized.

Copy link
@mdashti

mdashti Aug 15, 2018

@cstjean Can you please elaborate on the "1.0 compatibility". I could not find the reference to the change in how packages are marked as __precompile__(true) in 1.0. I'm not sure whether changing the REQUIRE is enough, but it's necessary to also add a major revision to MacroTools package after this change, so that all the dependencies that import it wouldn't have get affected.

This comment has been minimized.

Copy link
@cstjean

cstjean Aug 15, 2018

Collaborator

JuliaLang/julia#26991

In 1.0, precompiling is the default, and __precompile__(true) is an error. I don't know how to handle both 0.6 and 0.7 simultaneously.

This comment has been minimized.

Copy link
@mdashti

mdashti Aug 15, 2018

@cstjean Thanks for the reference. @KristofferC suggested to "Conditionally execute it based on VERSION."

This comment has been minimized.

Copy link
@mdashti

mdashti Aug 15, 2018

@cstjean @MikeInnes I'd really appreciate if you could add this and issue a new version of this package.

module MacroTools

using Compat
Expand Down
4 changes: 2 additions & 2 deletions src/examples/threading.jl
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ macro >(exs...)
isexpr(ex, :block) ? thread(x, rmlines(ex).args...) :
Expr(:call, ex, x)

thread(x, exs...) = reduce(thread, x, exs)
thread(x, exs...) = reduce(thread, exs, init=x)

esc(thread(exs...))
end
Expand All @@ -42,7 +42,7 @@ macro >>(exs...)
isexpr(ex, :block) ? thread(x, rmlines(ex).args...) :
Expr(:call, ex, x)

thread(x, exs...) = reduce(thread, x, exs)
thread(x, exs...) = reduce(thread, exs, init=x)

esc(thread(exs...))
end

0 comments on commit 18448ba

Please sign in to comment.