Support Adapt.jl v4

[vpuri3]

cc: @maleadt. Hopefully this should just work: I didn't find any reference to Adapt.eltype or Adapt.ndims in the repo with grep.

[vpuri3]

@maleadt can you help me understand the error here?

https://github.com/FluxML/Flux.jl/actions/runs/7714124765/job/21025646354?pr=2374#step:6:41

[christiangnrd]

That's because AMDGPU.jl doesn't yet support LLVM 16 which is Julia nightly's current version.

[ToucheSir]

This is a dupe of #2362, FYI.

[vpuri3]

Ah, glad it's being worked on. Sorry for the dupe

[vpuri3]

@ToucheSir , just spoke to @christiangnrd . We're abandoning #2362 in favor of this PR. Can you run workflows here?

[christiangnrd]

I did not say that and I don’t have any authority to make those decisions.

What I meant is that the other PR doesn’t update the Metal compat so if you remove the adapt fix here it could (not would) get merged for that and then allow the tests on the original PR to pass.

[vpuri3]

Apologies for mis-phrasing.

The changes in #2362 are already in this PR, along with the Metal compat update. So this PR should (hopefully) pass.

[ToucheSir]

I guess opening a new PR worked out because the Metal.jl compat bump was also required, thanks. Could you bump the package version quickly so that we can tag immediately after merging?

[vpuri3]

@ToucheSir done. Thank you