Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose RNG in initializers #1292

Merged
merged 4 commits into from
Jul 25, 2020
Merged

Expose RNG in initializers #1292

merged 4 commits into from
Jul 25, 2020

Conversation

findmyway
Copy link
Contributor

@findmyway findmyway commented Jul 24, 2020 •
edited
Loading

This fixes #1274 . Beyond that, a handy function (initializer(rng) where initializer may be glorot_uniform, glorot_normal, etc) is added to create an initializer with specific RNG.

PR Checklist

  • Tests are added. (This pr is simple enough. I can add if required)
  • Entry in NEWS.md
  • Documentation, if applicable.
  • Final review from @DhairyaLGandhi (for API changes).

CarloLucibello
CarloLucibello reviewed Jul 25, 2020
View reviewed changes
src/utils.jl Outdated Show resolved Hide resolved
@CarloLucibello CarloLucibello mentioned this pull request Jul 25, 2020
Closed
@CarloLucibello
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 25, 2020

Build succeeded:

@bors bors bot merged commit 71c567e into FluxML:master Jul 25, 2020
@ablaom ablaom mentioned this pull request Sep 16, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarloLucibello CarloLucibello CarloLucibello left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose the RNGs used in initialization to the user
2 participants
@findmyway @CarloLucibello