Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[F3D] Fix binary exports #407

Merged
merged 3 commits into from
Aug 8, 2024
Merged

[F3D] Fix binary exports #407

merged 3 commits into from
Aug 8, 2024

Conversation

Lilaa3
Copy link
Collaborator

@Lilaa3 Lilaa3 commented Aug 7, 2024

If any flag was 0 this would fail

@Lilaa3
[F3D] Fix binary exports
70671f8 
If any flag was 0 this would fail
@Lilaa3
Copy link
Collaborator Author

Lilaa3 commented Aug 7, 2024

minimal example.blend.zip
Since the user that reported this seems to be offline for now I made a minimal example, use the sm64 insertable binary exporter with ex2 as the microcode and a material with no geo mode flags enabled (there are other ways to trigger this but for the sake of simplicty this works), my file has this set up as is
I already tested and it fixed the issue!

Dragorn421
Dragorn421 approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@Dragorn421 Dragorn421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes what it ought to fix

@Dragorn421 Dragorn421 added bug Something isn't working merge soon Will be merged in a few days at most if nothing else comes up f3d Has to do with the "f3d" code common to all games labels Aug 7, 2024
@Lilaa3 Lilaa3 merged commit 00756ac into Fast-64:main Aug 8, 2024
1 check passed
@Lilaa3 Lilaa3 deleted the fix-f3d-binary-exports branch August 24, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dragorn421 Dragorn421 Dragorn421 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working f3d Has to do with the "f3d" code common to all games merge soon Will be merged in a few days at most if nothing else comes up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lilaa3 @Dragorn421