[SM64] Fixed Bug In Water Box Exports #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #355 |
Lilaa3
approved these changes
Jun 8, 2024
jesusyoshi54
added
the
merge soon
Lilaa3
added a commit
to Lilaa3/fast64
that referenced
this pull request
Aug 22, 2024
The previous fix was incomplete but the issue was never noticed from how uncommon camera volumes are. Previous fix was a fix to Fast-64#339
Lilaa3
added a commit
to Lilaa3/fast64
that referenced
this pull request
Aug 22, 2024
The previous fix was incomplete but the issue was never noticed from how uncommon camera volumes are. Previous fix was a fix to Fast-64#339
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug introduced in #339 woops lol.
I just did something simple here, the swap between quats and euler objects should be isomorphic (I can't actually prove this it has been a while since maths) so there is no loss in info.