Blender Version 4.1 Fix #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dragorn421
approved these changes
Apr 13, 2024
There was a problem hiding this comment.
Nice, thanks
On the code side:
The release notes
https://developer.blender.org/docs/release_notes/4.1/python_api/
mention the function was removed and the recomputation of normals is now automatic, so the changes here make sense
On testing:
Reonu found no issue from a quick test
https://discord.com/channels/874816709855440926/874816710639767585/1227970692826271797
|
This should be a release btw. The readme explicitly recommends "blender 4.0+". The updater should really take people to this version ASAP after the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Normals are always calculated from version 4.1 onwards, making the use of
calc_normals_split()unnecessary