Removed tex1 related code from BSDF to F3D converter #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lilaa3
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Why Subsurface Color in the first place? I can't even find a color input for the subsurface color in the principled BSDF shader so I assume it was removed in 4.0 along with the other shader changes? Either way using subsurface color for tex1 makes little sense, lgtm.
|
I actually checked discord, it was for avoiding using f3d nodes back in the ancient days, I guess that makes sense |
Dragorn421
added
the
merge soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.