Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some f3d parser cleanup #276

Merged
merged 6 commits into from
Feb 27, 2024
Merged

Some f3d parser cleanup #276

merged 6 commits into from
Feb 27, 2024

Conversation

Dragorn421
Copy link
Contributor

I did not break importing OoT scenes so it must be fine 4Head

@Dragorn421 Dragorn421 added codebase Code maintenance/cleanup f3d Has to do with the "f3d" code common to all games labels Jan 6, 2024
Yanis42
Yanis42 reviewed Jan 6, 2024
View reviewed changes
Copy link
Contributor

@Yanis42 Yanis42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk much about f3d but code looks ok to me (I haven't tried this yet)

@jesusyoshi54
Copy link
Collaborator

While testing this I found out that sm64 straight up does not work with the f3d importer. I am not surprised at all.

I then tested the f3d importer with some Kirby display lists that I exported and it worked just fine. So therefore I approve :)

jesusyoshi54
jesusyoshi54 approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@jesusyoshi54 jesusyoshi54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like sm64 didn't work before, or after this. That will be something to address in a different PR which is probably a long time coming for the f3d importer.

@Dragorn421
Copy link
Contributor Author

Thanks
I'd like to wait for #271 to be in before merging this in case it conflicts

@Dragorn421 Dragorn421 added the merge soon Will be merged in a few days at most if nothing else comes up label Feb 15, 2024
@Dragorn421
Copy link
Contributor Author

merged main and #271, seems to be fine still :) will merge soon tm

@Dragorn421 Dragorn421 merged commit d30239f into Fast-64:main Feb 27, 2024
1 check passed
@Dragorn421 Dragorn421 deleted the cleanup_f3d_parser branch February 27, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yanis42 Yanis42 Yanis42 left review comments

@jesusyoshi54 jesusyoshi54 jesusyoshi54 approved these changes

Assignees
No one assigned
Labels
codebase Code maintenance/cleanup f3d Has to do with the "f3d" code common to all games merge soon Will be merged in a few days at most if nothing else comes up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dragorn421 @jesusyoshi54 @Yanis42