Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM] Basic ActorList.xml #234

Merged
merged 9 commits into from
Nov 10, 2023
Merged

[MM] Basic ActorList.xml #234

merged 9 commits into from
Nov 10, 2023

Conversation

HailToDodongo
Copy link
Contributor

@HailToDodongo HailToDodongo commented Jul 9, 2023

As discussed in discord, this PR adds a basic actor XML file for MM.
Basically all actor params are still missing, but i will make commits from time to time.
The other changes in the oot XML are either small fixes or making a few texts shorter to fit within the UI better.
I also replaced the weird Unicode with regular ones ', since i had a few encoding issues in my editor with it.

One difference in the format itself compared to oot is, that i used the enum name instead of the variable name for ObjectKey.
This makes it easier for me, since the enum is what gets saved anyways and is just as unique.

@Yanis42
Copy link
Contributor

Yanis42 commented Jul 9, 2023

I don't think it matters right now but just in case: the idea behind actor "key" is avoid the thing to break if the actor's ID changes, though it's probably fine with MM (it's not even used currently so if we really need it we can always add them later)

@HailToDodongo
Copy link
Contributor Author

Ah right, i completely forgot that one.
I don't really want to pull actual names out since i have no need for them, but i guess initially setting this to a lower-case version of the enum would be fine?

Copy link
Contributor

@Yanis42 Yanis42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small thing I noticed

fast64_internal/oot/data/xml/ActorList.xml Outdated Show resolved Hide resolved
@Yanis42
Copy link
Contributor

Yanis42 commented Jul 9, 2023

Ah right, i completely forgot that one. I don't really want to pull actual names out since i have no need for them, but i guess initially setting this to a lower-case version of the enum would be fine?

yeah, the actor key is it's debug name (like ACTOR_EN_TEST) without the actor part and lowercased, I made it that way since we already use those a lot for years

@Yanis42
Copy link
Contributor

Yanis42 commented Jul 9, 2023

but again, it won't really matter until we're implementing MM, which should probably be done once OoT is cleaned up (it takes a lot of time unfortunately)

also I originally made the OoT XML file to create a more detailed actor panel on Fast64, that's why there's some useless informations right now

btw thanks a lot for doing this, it's really cool to have something to work with!

@HailToDodongo
Copy link
Contributor Author

no problem.
I fixed the order and added a key to the mm actors.

Btw, if you're interested or if there where issues implementing parameters in fast64, i made some changes via a conversion script in my project to make it easier to handle in my UI.

Copy link
Contributor

@Yanis42 Yanis42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

documentation is cool

@Yanis42 Yanis42 added merge soon Will be merged in a few days at most if nothing else comes up oot Has to do with the Ocarina of Time 64 side mm labels Nov 8, 2023
@Yanis42 Yanis42 merged commit fa99be4 into Fast-64:main Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge soon Will be merged in a few days at most if nothing else comes up mm oot Has to do with the Ocarina of Time 64 side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants