Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP8: Add required 3rd param for Joomla #2265

Merged
merged 2 commits into from
Feb 19, 2022
Merged

PHP8: Add required 3rd param for Joomla #2265

merged 2 commits into from
Feb 19, 2022

Conversation

skurvish
Copy link

With PHP8 when trying to unpublish a group, get the following error:

Fatal error: Declaration of & FabrikAdminControllerGroups::getModel($name = 'Group', $prefix = 'FabrikAdmi...') must be compatible with Joomla\CMS\MVC\Controller\BaseController::getModel($name = '', $prefix = '', $config = []) in /var/www/html/administrator/components/com_fabrik/controllers/groups.php on line 48

This PR adds the config parameter

@trob
Copy link

trob commented Feb 19, 2022

All other controllers are doing
public function getModel($name = 'List', $prefix = 'FabrikAdminModel', $config = array())
so maybe you can change this?

@skurvish
Copy link
Author

Done.

@trob trob merged commit 85465c4 into Fabrik:master Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants