Implementing map_seal and bind_seal primitive operators #3074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful to debug specific norm calls in tactics or norm requests without turning on a "global" flag, which would also trigger debugging for any request the typechecker does.
|
I think this is good to merge, but I'd wait for hacl-star/hacl-star#873 since I think it will randomly break Ed25519 (it did locally). |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
map_sealandbind_sealtoFStar.Sealed.fsti. Implementing them properly in the normalizer requires support for 'renormalization' after a primitive step reduces, which we did not have, as every primop so far was returning a value.