Add OCaml realization for Int.Cast #2315
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniolocascio
force-pushed
the
antoniolocascio_2303
branch
from
58bb10f
to
8e485a1
Compare
|
For now, I just used the old extracted F# code for |
ulib/fs/FStar_Int_Cast.fs
Outdated
| (* !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! *) | ||
| (* THIS FILE WAS EXTRACTED FROM F* *) | ||
| (* IT HAS TO BE COPIED HERE BECAUSE THIS MODULE IS NOW REALIZED IN | ||
| OCAML *) |
There was a problem hiding this comment.
Wouldn't it be fine to leave both fst and fsti in ulib, and only add OCaml implementation inside ml subdirectory? I'm not 100% sure, but afair F* was smart enough to use the realized module if it was available and otherwise rely on extraction.
With F#, what is being used is driven with fsproj, but I'm not completely sure how makefiles for OCaml will behave with both fst and ml files present.
There was a problem hiding this comment.
@mateuszbujalski I didn’t realize I could do that, it's much cleaner that way. Thanks!
antoniolocascio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #2303.
As explained on the issue, giving an OCaml realization to the
Int.Castmodule improves its performance significantly.