Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "chore" type #18

Merged
merged 3 commits into from
Mar 17, 2023
Merged

Add "chore" type #18

merged 3 commits into from
Mar 17, 2023

Conversation

AlexHodson
Copy link
Contributor

Adds "chore" type to the default commit type options. Addresses #17

@sonyarianto
Copy link
Contributor

@AlexHodson exactly what I want haha :) thanks.

@@ -1,19 +1,80 @@
{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AlexHodson I appreciate the help. :)

Everything looks good. But you don't need to change this file. This is the config for this repository.

Anything that is not supplied gets replaced by the defaults at run-time. So you should see your change regardless of adding it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, I see. I must have run the "init" npm script which caused the changes. I have reverted the better-commits.json file back to its original state.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup no worries, great job and thanks again! Merged.

@Everduin94 Everduin94 merged commit 396b985 into Everduin94:main Mar 17, 2023
github-actions bot pushed a commit that referenced this pull request Apr 12, 2023
# 1.0.0 (2023-04-12)

### Bug Fixes

* **main:** Fixed undefined when ticket is empty ([#13](#13)) ([80e819a](80e819a))
* **tools:** Replace git branch get name method ([#5](#5)) ([12feba8](12feba8))

* Merge pull request from Everduin94/everduin94/feat/1-improve-docs ([13bb314](13bb314)), closes [#1](#1) [#1](#1)
* feat(tools)!: #1 This is an example commit ([6342aca](6342aca)), closes [#1](#1) [#1](#1)

### Features

* **main:** [#10](#10) add hints to default types ([#11](#11)) ([ae97cd1](ae97cd1))
* **main:** [#14](#14) print commit output ([#15](#15)) ([86cbf0c](86cbf0c))
* **main:** Add "chore" type to defaults ([#18](#18)) ([396b985](396b985))
* **main:** add license and minor fixes ([#25](#25)) ([62deffb](62deffb)), closes [#22](#22) [#23](#23) [#24](#24)
* **main:** custom scope prompt ([#21](#21)) ([858cce7](858cce7)), closes [#20](#20)
* **main:** testing github action ([0c3a08a](0c3a08a))
* **main:** testing github action ([04966a3](04966a3))
* **main:** testing github workflow ([4baca59](4baca59))
* **tools:** [#3](#3) infer ticket/issue from branch ([#4](#4)) ([bae6601](bae6601))
* **tools:** added custom footer option ([#9](#9)) ([1df1d82](1df1d82))
* **tools:** Initial commit of better-commits to public repository ([21aa536](21aa536))

### BREAKING CHANGES

* Fake breaking change

Making a fake breaking change as an example
* Fake breaking change

Making a fake breaking change as an example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants