This repository has been archived by the owner on Jan 26, 2023. It is now read-only.
New sample: setup-location-driven-geotriggers #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham7109
changed the title
TADraeseke
suggested changes
Aug 17, 2021
There was a problem hiding this comment.
Thanks @shubham7109 -- just some comments in line.
I like the play/pause functionality.
As to the top UI. Is there a reason the Points of interest areas is so much larger than the Current Garden Section (let's make those section titles sentence case)? Can they both be the same size?
The N/A doesn't seem very useful for Points of interest. Maybe the UI should be smaller when there aren't any or even disappear entirely?
...s/src/main/java/com/esri/arcgisruntime/sample/setuplocationdrivengeotriggers/MainActivity.kt
Outdated
Show resolved
Hide resolved
...s/src/main/java/com/esri/arcgisruntime/sample/setuplocationdrivengeotriggers/MainActivity.kt
Outdated
Show resolved
Hide resolved
kotlin/setup-location-driven-geotriggers/src/main/res/layout/activity_main.xml
Outdated
Show resolved
Hide resolved
kotlin/setup-location-driven-geotriggers/src/main/res/layout/activity_main.xml
Outdated
Show resolved
Hide resolved
kotlin/setup-location-driven-geotriggers/src/main/res/layout/list_item.xml
Outdated
Show resolved
Hide resolved
...s/src/main/java/com/esri/arcgisruntime/sample/setuplocationdrivengeotriggers/MainActivity.kt
Outdated
Show resolved
Hide resolved
kotlin/setup-location-driven-geotriggers/src/main/res/layout/activity_main.xml
Outdated
Show resolved
Hide resolved
kotlin/setup-location-driven-geotriggers/src/main/res/layout/dialog_fragment.xml
Show resolved
Hide resolved
kotlin/setup-location-driven-geotriggers/src/main/res/values/strings.xml
Outdated
Show resolved
Hide resolved
|
TADraeseke
suggested changes
Aug 24, 2021
There was a problem hiding this comment.
Just a few small things--behaviour of the app looks good, thanks @shubham7109!
...s/src/main/java/com/esri/arcgisruntime/sample/setuplocationdrivengeotriggers/MainActivity.kt
Outdated
Show resolved
Hide resolved
...s/src/main/java/com/esri/arcgisruntime/sample/setuplocationdrivengeotriggers/MainActivity.kt
Outdated
Show resolved
Hide resolved
...s/src/main/java/com/esri/arcgisruntime/sample/setuplocationdrivengeotriggers/MainActivity.kt
Outdated
Show resolved
Hide resolved
...s/src/main/java/com/esri/arcgisruntime/sample/setuplocationdrivengeotriggers/MainActivity.kt
Outdated
Show resolved
Hide resolved
...s/src/main/java/com/esri/arcgisruntime/sample/setuplocationdrivengeotriggers/MainActivity.kt
Outdated
Show resolved
Hide resolved
...s/src/main/java/com/esri/arcgisruntime/sample/setuplocationdrivengeotriggers/MainActivity.kt
Outdated
Show resolved
Hide resolved
...s/src/main/java/com/esri/arcgisruntime/sample/setuplocationdrivengeotriggers/MainActivity.kt
Outdated
Show resolved
Hide resolved
...s/src/main/java/com/esri/arcgisruntime/sample/setuplocationdrivengeotriggers/MainActivity.kt
Outdated
Show resolved
Hide resolved
kotlin/setup-location-driven-geotriggers/src/main/res/values/colors.xml
Outdated
Show resolved
Hide resolved
TADraeseke
added a commit
that referenced
this pull request
Aug 25, 2021
* add artifactory * remove progress indicator on failed trace, trace utility netowrk * 100.11.2 * update gradle or kotlin version * Browse OGC API feature service (#886) * add sample, screenshot and README * fix build.gradle * pull from v.next * small fixes * PR fixes * update gradle * update gradle to 6.7.1 * version updates * Update README.md * Trev8939/update locators (#892) * find address and find place done * update offline geocode * move samples back to kotlin extensions until workaround is found (#894) * move samples back to kotlin extensions until workaround is found * add missing copyright * unify arcgis vector tiled layer custom style naming * Shu11698/v.next fixes (#895) * Fixed Add stop and barriers text * ListView is visible, made some minor UI improvements Increased text size and centered layout for readability. Co-authored-by: Shubham Sharma <[email protected]> * Use defaultTraceConfiguration instead of traceConfiguration (#898) * use defaultTraceConfiguration instead of traceConfiguration * Update README.md * Removed artifact link (#900) * reanble buttons in trace utility network after error * Update build.gradle * New Sample: Query with CQL filters (#899) * working update with screenshots, READMEs and metadata updated (#904) * add intent flags and URI handling (#906) * Create save map no folder crash fix (#905) * check for no folder selected from server, is user has no folders * invert if * add option to save to no folder * Patches to CQL Filters (#909) * Open map url update (#910) * Fixed incorrect image file name (#911) * target 100.12 * New sample: setup-location-driven-geotriggers (#907) * working prototype * rename and add scrollview * Added garden section and POI interactions * Cleaning up code! * Attached dialog to listView * Create README.md * Comments and reformatting code * more comments and reformatting * Add files via upload * Update README.md * Create README.metadata.json * Update README.metadata.json * Added copyright * Update README.md * Layered mapview and reduced POIs size * Resolved PR comments * Image attachments are now retrieved on click. * Log statements for list items. Not fixed yet. * Fixed wrap_content issue. * Resolving comments * Revert to KotlinX * small fixes to metadata and readme to fix sample viewer Co-authored-by: trev8939 <[email protected]> * CQL Filters patch (#912) * Query with CQL sample progress * Added comments * Code cleanup * Added zoom using setViewpointGeometryAsync * Create README.md * Add files via upload * Create README.metadata.json * Delete QueryWithCQLFilters.png * Add files via upload * Update README.md * Update README.metadata.json * Changed package name * Update AndroidManifest.xml * Added copyright * Convert to viewbinding * Code cleanup * Update MainActivity.kt * Update README.metadata.json * Resolved PR comments * Removed unwanted line * Updated snipped directory name * Set alert dialog to show "Empty Query" option * Changed to "No Query" * Update MainActivity.kt * Delete query-with-cql-features.png * Add files via upload * Update README.md * Removed viewbinding * Update README.md Co-authored-by: Shubham Sharma <[email protected]> Co-authored-by: Shubham Sharma <[email protected]>
TADraeseke
added a commit
that referenced
this pull request
Aug 26, 2021
* add artifactory * remove progress indicator on failed trace, trace utility netowrk * 100.11.2 * update gradle or kotlin version * Browse OGC API feature service (#886) * add sample, screenshot and README * fix build.gradle * pull from v.next * small fixes * PR fixes * update gradle * update gradle to 6.7.1 * version updates * Update README.md * Trev8939/update locators (#892) * find address and find place done * update offline geocode * move samples back to kotlin extensions until workaround is found (#894) * move samples back to kotlin extensions until workaround is found * add missing copyright * unify arcgis vector tiled layer custom style naming * Shu11698/v.next fixes (#895) * Fixed Add stop and barriers text * ListView is visible, made some minor UI improvements Increased text size and centered layout for readability. Co-authored-by: Shubham Sharma <[email protected]> * Use defaultTraceConfiguration instead of traceConfiguration (#898) * use defaultTraceConfiguration instead of traceConfiguration * Update README.md * Removed artifact link (#900) * reanble buttons in trace utility network after error * Update build.gradle * New Sample: Query with CQL filters (#899) * working update with screenshots, READMEs and metadata updated (#904) * add intent flags and URI handling (#906) * Create save map no folder crash fix (#905) * check for no folder selected from server, is user has no folders * invert if * add option to save to no folder * Patches to CQL Filters (#909) * Open map url update (#910) * Fixed incorrect image file name (#911) * New sample: setup-location-driven-geotriggers (#907) * working prototype * rename and add scrollview * Added garden section and POI interactions * Cleaning up code! * Attached dialog to listView * Create README.md * Comments and reformatting code * more comments and reformatting * Add files via upload * Update README.md * Create README.metadata.json * Update README.metadata.json * Added copyright * Update README.md * Layered mapview and reduced POIs size * Resolved PR comments * Image attachments are now retrieved on click. * Log statements for list items. Not fixed yet. * Fixed wrap_content issue. * Resolving comments * Revert to KotlinX * small fixes to metadata and readme to fix sample viewer Co-authored-by: trev8939 <[email protected]> * CQL Filters patch (#912) * Query with CQL sample progress * Added comments * Code cleanup * Added zoom using setViewpointGeometryAsync * Create README.md * Add files via upload * Create README.metadata.json * Delete QueryWithCQLFilters.png * Add files via upload * Update README.md * Update README.metadata.json * Changed package name * Update AndroidManifest.xml * Added copyright * Convert to viewbinding * Code cleanup * Update MainActivity.kt * Update README.metadata.json * Resolved PR comments * Removed unwanted line * Updated snipped directory name * Set alert dialog to show "Empty Query" option * Changed to "No Query" * Update MainActivity.kt * Delete query-with-cql-features.png * Add files via upload * Update README.md * Removed viewbinding * Update README.metadata.json * Changed module name to "set-up" instead of "setup" * Update README.metadata.json * Delete setup-location-driven-geotriggers.png * Add files via upload * Update README.md * Update README.metadata.json * Update build.gradle Co-authored-by: trev8939 <[email protected]> Co-authored-by: Shubham Sharma <[email protected]>
TADraeseke
added a commit
that referenced
this pull request
Oct 29, 2021
* add artifactory * remove progress indicator on failed trace, trace utility netowrk * 100.11.2 * update gradle or kotlin version * Browse OGC API feature service (#886) * add sample, screenshot and README * fix build.gradle * pull from v.next * small fixes * PR fixes * update gradle * update gradle to 6.7.1 * version updates * Update README.md * Trev8939/update locators (#892) * find address and find place done * update offline geocode * move samples back to kotlin extensions until workaround is found (#894) * move samples back to kotlin extensions until workaround is found * add missing copyright * unify arcgis vector tiled layer custom style naming * Shu11698/v.next fixes (#895) * Fixed Add stop and barriers text * ListView is visible, made some minor UI improvements Increased text size and centered layout for readability. Co-authored-by: Shubham Sharma <[email protected]> * Use defaultTraceConfiguration instead of traceConfiguration (#898) * use defaultTraceConfiguration instead of traceConfiguration * Update README.md * Removed artifact link (#900) * reanble buttons in trace utility network after error * Update build.gradle * New Sample: Query with CQL filters (#899) * working update with screenshots, READMEs and metadata updated (#904) * add intent flags and URI handling (#906) * Create save map no folder crash fix (#905) * check for no folder selected from server, is user has no folders * invert if * add option to save to no folder * Patches to CQL Filters (#909) * Open map url update (#910) * Fixed incorrect image file name (#911) * New sample: setup-location-driven-geotriggers (#907) * working prototype * rename and add scrollview * Added garden section and POI interactions * Cleaning up code! * Attached dialog to listView * Create README.md * Comments and reformatting code * more comments and reformatting * Add files via upload * Update README.md * Create README.metadata.json * Update README.metadata.json * Added copyright * Update README.md * Layered mapview and reduced POIs size * Resolved PR comments * Image attachments are now retrieved on click. * Log statements for list items. Not fixed yet. * Fixed wrap_content issue. * Resolving comments * Revert to KotlinX * small fixes to metadata and readme to fix sample viewer Co-authored-by: trev8939 <[email protected]> * CQL Filters patch (#912) * Query with CQL sample progress * Added comments * Code cleanup * Added zoom using setViewpointGeometryAsync * Create README.md * Add files via upload * Create README.metadata.json * Delete QueryWithCQLFilters.png * Add files via upload * Update README.md * Update README.metadata.json * Changed package name * Update AndroidManifest.xml * Added copyright * Convert to viewbinding * Code cleanup * Update MainActivity.kt * Update README.metadata.json * Resolved PR comments * Removed unwanted line * Updated snipped directory name * Set alert dialog to show "Empty Query" option * Changed to "No Query" * Update MainActivity.kt * Delete query-with-cql-features.png * Add files via upload * Update README.md * Removed viewbinding * remove wrong geotriggers sample * Update build.gradle * New sample: NMEA Location Data Source (#917) * New module script (#919) Script to automate creating a new sample using a basic template. Added `README` files with instructions on how to use the script and how the script works. * Update samples from named user to API keys (#923) - Generate offline map (Java & Kotlin) - Generate offline map override (Java) - Generate offline map with local basemap (Java) - Create and save map (Java) - Navigate in AR (Java) * Update sample to use .tpkx (#920) Samples updated: - Offline Routing (Kotlin) - Generate geodatabase (Kotlin & Java) - Offline geocode (Kotlin & Java) - Create terrain from local tile package (Kotlin & Java) - Edit and sync features (Kotlin & Java) - Export tiles. Also fixed the the crash on the Sample Viewer. (Kotlin & Java) - Generate offline map with local basemap (Java) - Arcgis tiled layer (Java) Updated `README.md` and meta data json files as well to reflect the `.tpkx` to be used. * Removed line to clear cache dir (#924) * New sample: Show Popup (#922) * Implemented sample. Need to fix binding issue * Kotlin kapt addded * Popup Toolkit implemented using databinding * Code cleanup * Fixed image size * Update build.gradle * Removed provision from * Resolve PR comments * Resolving PR * Update README.metadata.json Co-authored-by: trev8939 <[email protected]> Co-authored-by: Mike Wilburn <[email protected]> * PR to update v.next with main (#925) * remove wrongly named geotriggers sample * Update API version mentioned in root README (#916) * use selectFeatures instead of selectFeature (#921) * use selectFeatures instead of selectFeature * Update kotlin/feature-layer-selection/src/main/java/com/esri/arcgisruntime/sample/featurelayerselection/MainActivity.kt Co-authored-by: Rachael Ellen <[email protected]> Co-authored-by: Rachael Ellen <[email protected]> Co-authored-by: trev8939 <[email protected]> Co-authored-by: Mike Wilburn <[email protected]> Co-authored-by: Rachael Ellen <[email protected]> Co-authored-by: Shubham Sharma <[email protected]> Co-authored-by: Shubham Sharma <[email protected]> Co-authored-by: Mike Wilburn <[email protected]> Co-authored-by: Rachael Ellen <[email protected]>
shubham7109
added a commit
that referenced
this pull request
Dec 16, 2021
* add artifactory * remove progress indicator on failed trace, trace utility netowrk * 100.11.2 * update gradle or kotlin version * Browse OGC API feature service (#886) * add sample, screenshot and README * fix build.gradle * pull from v.next * small fixes * PR fixes * update gradle * update gradle to 6.7.1 * version updates * Update README.md * Trev8939/update locators (#892) * find address and find place done * update offline geocode * move samples back to kotlin extensions until workaround is found (#894) * move samples back to kotlin extensions until workaround is found * add missing copyright * unify arcgis vector tiled layer custom style naming * Shu11698/v.next fixes (#895) * Fixed Add stop and barriers text * ListView is visible, made some minor UI improvements Increased text size and centered layout for readability. Co-authored-by: Shubham Sharma <[email protected]> * Use defaultTraceConfiguration instead of traceConfiguration (#898) * use defaultTraceConfiguration instead of traceConfiguration * Update README.md * Removed artifact link (#900) * reanble buttons in trace utility network after error * Update build.gradle * New Sample: Query with CQL filters (#899) * working update with screenshots, READMEs and metadata updated (#904) * add intent flags and URI handling (#906) * Create save map no folder crash fix (#905) * check for no folder selected from server, is user has no folders * invert if * add option to save to no folder * Patches to CQL Filters (#909) * Open map url update (#910) * Fixed incorrect image file name (#911) * New sample: setup-location-driven-geotriggers (#907) * working prototype * rename and add scrollview * Added garden section and POI interactions * Cleaning up code! * Attached dialog to listView * Create README.md * Comments and reformatting code * more comments and reformatting * Add files via upload * Update README.md * Create README.metadata.json * Update README.metadata.json * Added copyright * Update README.md * Layered mapview and reduced POIs size * Resolved PR comments * Image attachments are now retrieved on click. * Log statements for list items. Not fixed yet. * Fixed wrap_content issue. * Resolving comments * Revert to KotlinX * small fixes to metadata and readme to fix sample viewer Co-authored-by: trev8939 <[email protected]> * CQL Filters patch (#912) * Query with CQL sample progress * Added comments * Code cleanup * Added zoom using setViewpointGeometryAsync * Create README.md * Add files via upload * Create README.metadata.json * Delete QueryWithCQLFilters.png * Add files via upload * Update README.md * Update README.metadata.json * Changed package name * Update AndroidManifest.xml * Added copyright * Convert to viewbinding * Code cleanup * Update MainActivity.kt * Update README.metadata.json * Resolved PR comments * Removed unwanted line * Updated snipped directory name * Set alert dialog to show "Empty Query" option * Changed to "No Query" * Update MainActivity.kt * Delete query-with-cql-features.png * Add files via upload * Update README.md * Removed viewbinding * remove wrong geotriggers sample * Update build.gradle * New sample: NMEA Location Data Source (#917) * New module script (#919) Script to automate creating a new sample using a basic template. Added `README` files with instructions on how to use the script and how the script works. * Update samples from named user to API keys (#923) - Generate offline map (Java & Kotlin) - Generate offline map override (Java) - Generate offline map with local basemap (Java) - Create and save map (Java) - Navigate in AR (Java) * Update sample to use .tpkx (#920) Samples updated: - Offline Routing (Kotlin) - Generate geodatabase (Kotlin & Java) - Offline geocode (Kotlin & Java) - Create terrain from local tile package (Kotlin & Java) - Edit and sync features (Kotlin & Java) - Export tiles. Also fixed the the crash on the Sample Viewer. (Kotlin & Java) - Generate offline map with local basemap (Java) - Arcgis tiled layer (Java) Updated `README.md` and meta data json files as well to reflect the `.tpkx` to be used. * Removed line to clear cache dir (#924) * New sample: Show Popup (#922) * Implemented sample. Need to fix binding issue * Kotlin kapt addded * Popup Toolkit implemented using databinding * Code cleanup * Fixed image size * Update build.gradle * Removed provision from * Resolve PR comments * Resolving PR * Update README.metadata.json Co-authored-by: trev8939 <[email protected]> Co-authored-by: Mike Wilburn <[email protected]> * PR to update v.next with main (#925) * remove wrongly named geotriggers sample * Update API version mentioned in root README (#916) * use selectFeatures instead of selectFeature (#921) * use selectFeatures instead of selectFeature * Update kotlin/feature-layer-selection/src/main/java/com/esri/arcgisruntime/sample/featurelayerselection/MainActivity.kt Co-authored-by: Rachael Ellen <[email protected]> Co-authored-by: Rachael Ellen <[email protected]> Co-authored-by: trev8939 <[email protected]> Co-authored-by: Mike Wilburn <[email protected]> Co-authored-by: Rachael Ellen <[email protected]> * Minor patches to samples (#928) * update version.gradle * Fix for U13 (#931) * Update version.gradle * Pull main into v.next (#932) * PR to use ViewBinding for Android ArcGIS Samples (#902) * Remove metadata script (#930) Co-authored-by: Shubham Sharma <[email protected]> * Gradle and JDK upgrade (#935) * Readme updates from February 22nd to November 12th (#937) * PR to use ViewBinding for Android ArcGIS Samples (#902) * Remove metadata script (#930) * Readme updates Co-authored-by: Trevor Draeseke <[email protected]> * update gradle wrappers, build.versions and version.gradle * update version.gradle * New sample: Browse Building Floors (#936) * Update MainActivity.kt Co-authored-by: Shubham Sharma <[email protected]> Co-authored-by: Shubham Sharma <[email protected]> Co-authored-by: Mike Wilburn <[email protected]> Co-authored-by: Rachael Ellen <[email protected]> Co-authored-by: Trevor Draeseke <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to add Geotriggers to the Android Sample Viewer.