Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration guide updates next #1909

Merged
merged 6 commits into from
Sep 20, 2024
Merged

Migration guide updates next #1909

merged 6 commits into from
Sep 20, 2024

Conversation

achapkowski
Copy link
Contributor

updated guide 6 for network analysis

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

review-notebook-app bot commented Sep 13, 2024

View / edit / reply to this conversation on ReviewNB

jyaistMap commented on 2024-09-13T22:42:48Z
----------------------------------------------------------------

Can you confirm the results? The original guide had a number of points symbolized in the results. Can you update the map image?


Copy link
Collaborator

@jyaistMap jyaistMap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@achapkowski @nanaeaubry

  • the guide looks good - but the map display for map1 in the first example looks different from the original in that it looks like point symbols are not displaying. Can you check that out?

@nanaeaubry
Copy link
Contributor

@jyaistMap I can see the points on map 1:

image

This is with latest build

@jyaistMap
Copy link
Collaborator

@nanaeaubry @achapkowski

@jyaistMap I can see the points on map 1:

image

This is with latest build

The map on production and in the original notebook looks like this:
image

Has the data changed so that all those surrounding points are no longer in the data?

@nanaeaubry
Copy link
Contributor

@jyaistMap AH! It seems the picture marker symbol might not exists anymore. Will change that!

@nanaeaubry
Copy link
Contributor

@jyaistMap The picture marker doesn't seem to exist anymore, I changed to simple marker symbol and updated the screenshot. Doesn't look as nice but we can look into finding another picture marker in another update

@jyaistMap
Copy link
Collaborator

Thanks @nanae! Looks good locally and in nbreview

@jyaistMap jyaistMap merged commit 5a5739b into next Sep 20, 2024
2 checks passed
@achapkowski achapkowski deleted the migration_guide_updates_next branch September 20, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants