Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[faiss 1.7.1] Impl RefineFlatIndex #25

Merged
merged 4 commits into from
Jun 21, 2021
Merged

[faiss 1.7.1] Impl RefineFlatIndex #25

merged 4 commits into from
Jun 21, 2021

Conversation

ava57r
Copy link
Collaborator

@ava57r ava57r commented May 13, 2021

@Enet4
Copy link
Owner

Enet4 commented May 27, 2021

We'll hopefully be able to review this PR and the other ones once facebookresearch/faiss#1915 is resolved.

@ava57r
Copy link
Collaborator Author

ava57r commented May 31, 2021

faiss release tagged v1.7.1

@Enet4 Enet4 changed the title [faiss unreleased] Impl RefineFlatIndex [faiss 1.7.1] Impl RefineFlatIndex May 31, 2021
Enet4
Enet4 requested changes Jun 12, 2021
View reviewed changes
Copy link
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one appears to have the same issues reported in #24. Please look into the pre-transform index and apply the same pattern of resolution here.

src/index/refine_flat.rs Outdated Show resolved Hide resolved
Enet4
Enet4 approved these changes Jun 21, 2021
View reviewed changes
Copy link
Owner

@Enet4 Enet4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thank you!

@Enet4 Enet4 merged commit 41b992c into Enet4:master Jun 21, 2021
@ava57r ava57r deleted the refine-2 branch November 28, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enet4 Enet4 Enet4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for IndexRefineFlat
2 participants
@ava57r @Enet4