Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to egui 0.29 #234

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

tedsteen
Copy link

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

Upgraded to egui 0.29.

Related Issues

Fixes #233

@emilk
Copy link
Collaborator

emilk commented Sep 30, 2024

How well have you tested this?

@tedsteen
Copy link
Author

tedsteen commented Oct 1, 2024

How well have you tested this?

To be honest with you.. Not at all :)
I plan to test this out on my own project when I find the time, so until then, unless someone else do some testing, we let this PR rest here..

@Azkellas
Copy link

Azkellas commented Oct 1, 2024

I tested it on my project (while bumping egui, egui-wgpu and egui-winit from 0.28.1 to 0.29.1) and haven't seen any issue so far. It even seems to be running faster but I haven't benchmarked properly.

@tedsteen
Copy link
Author

tedsteen commented Oct 1, 2024

I have now at least tried to run puffin and things are looking ok.
Will get back to you when I have done more extensive testing on my end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update puffin_egui to support egui 0.29
3 participants