Add setting for grid spacing on temporal axis #195
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to change the spacing of the x-axis indicators from the default 10ms to an arbitrary interval. This is particularly useful to determine when a frame misses its desired vblank.
This change is primarily motivated by my own necessity to easily determine when a particular frame ran for over ~16ms and specifically which part of the flamegraph caused it to stretch beyond that limit. It's probably not the ideal solution, but I wanted to open up a PR to see if there's any interest in this feature from upstream.
One particularity of the current implementation is that 1, 10, 100, and 1000 all behave the same, since the interval is somewhat relative to the current viewport's width. I don't care about this since it doesn't really make a difference (you just need to zoom in/out), but I can see how that might be an undesired user experience.
tmp.mp4