Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup initial cargo-vet crate auditing #141

Merged
merged 5 commits into from
Jun 8, 2023
Merged

Setup initial cargo-vet crate auditing #141

merged 5 commits into from
Jun 8, 2023

Conversation

repi
Copy link
Contributor

@repi repi commented Jun 8, 2023

Adds initial configurations for our crate auditing workflow with cargo-vet. This just adds the standard files and configures our imported registries as well as default trusted publishers.

Want to experiment with us using this auditing workflow in this public library crate as we've only been testing it so far on our larger private monorepo. This imports the audits from that through https://github.com/EmbarkStudios/rust-ecosystem/blob/main/audits.toml.

Copy link
Contributor Author

repi commented Jun 8, 2023

@repi repi mentioned this pull request Jun 8, 2023
@repi repi mentioned this pull request Jun 8, 2023
@repi repi added the graphite Stacked PR using Graphite label Jun 8, 2023 — with Graphite App
@repi repi marked this pull request as ready for review June 8, 2023 20:28
@repi repi requested review from emilk and TimonPost as code owners June 8, 2023 20:28
@repi repi merged commit d90b434 into main Jun 8, 2023
@repi repi deleted the cargo-vet-audit branch June 8, 2023 20:29
Copy link
Contributor Author

repi commented Jun 8, 2023

@repi merged this pull request with Graphite.

@repi
Copy link
Contributor Author

repi commented Jun 8, 2023

hmm this got merged by Graphite both before CI passed as well as before any reviews, that is definitely not what I would call "merge when ready" 😅 good to know! and something should investigate more. in this case didn't really hurt that was merged early, but still not great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graphite Stacked PR using Graphite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant