Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to egui 0.22 #137

Merged
merged 4 commits into from
May 24, 2023
Merged

Update to egui 0.22 #137

merged 4 commits into from
May 24, 2023

Conversation

emilk
Copy link
Collaborator

@emilk emilk commented May 23, 2023

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

puffin_viewer will now respect the system light mode or dark mode setting.

Also: puffin_viewer now has an icon!

icon

(yes, the license allows it: https://en.wikipedia.org/wiki/File:Papageitaucher_Fratercula_arctica.jpg)

@emilk emilk requested a review from TimonPost as a code owner May 23, 2023 19:26
Copy link
Member

@TimonPost TimonPost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rfd upgrade with its async dialogs seems pretty heavy dependency-wise. The upgrade brings in quite some deps in this PR. Perhaps we can revert it for the time being? Unfortunately, looks like it has no feature flag?

@emilk
Copy link
Collaborator Author

emilk commented May 24, 2023

Good call

@emilk
Copy link
Collaborator Author

emilk commented May 24, 2023

Note that most of the deps in the Cargo.lock are dev-dependencies only

@TimonPost
Copy link
Member

Will do a release directly after this is merged

@TimonPost TimonPost merged commit c361e77 into main May 24, 2023
@TimonPost TimonPost deleted the emilk/update-egui branch May 24, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants