Fix TransportBuilder for Magento2.3.5 compatibility #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttachment, update SenderBuilder to use TransportBuilder
|
In magento 2.3.6 The sales_send_order_invoice_emails cron job throws an exception with this PR. Which is true, because this patch replaces it with a TransportBuilder instance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove di for Message preference, update TransportBuilder to handle attachment, update SenderBuilder to use TransportBuilder
Module latest 12.10 allows PHP7.3 but dev dependencies for testing require <7.3 so no test for this PR. Fix the dev dependencies in the latest version and we can have tests here.