This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
failed deferred transactions were in history (6214) #6220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
approved these changes
Nov 2, 2018
Closed
arhag
suggested changes
Nov 2, 2018
arhag
approved these changes
Nov 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
The history plugin sometimes included failed deferred transactions in its history. Since it doesn't store receipt status, there wasn't a reliable way for users of the history API to know which actions were executed. #6214
As a reminder, the history plugin is deprecated. This fix is included because the bug opens an attack vector against apps which rely on data from the history plugin to make decisions.
Documentation Additions
This is a behavior change. Previously
get_transactioncould retrieve failed or expired deferred transactions.