Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDAT Migration Phase 2: Refactor arm_diags set #842

Merged
merged 35 commits into from
Oct 1, 2024
Merged
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
6d1a434
clean up arm_diags annual-cycle subset
chengzhuzhang Aug 26, 2024
1109188
update climo_xr for supporting annual cycle and performance
chengzhuzhang Aug 26, 2024
39a973d
more updates on climo_xr
chengzhuzhang Aug 28, 2024
e79a9db
finish annual_cycle(2d)
chengzhuzhang Aug 29, 2024
454f004
complete diurnal cycle (2d);enhance diurnal_cycle_xr performance
chengzhuzhang Aug 29, 2024
1f1ff50
update diurnal cycle zt
chengzhuzhang Sep 5, 2024
a43a1a6
update convection onset
chengzhuzhang Sep 5, 2024
5124e0f
update aerosol activation
chengzhuzhang Sep 6, 2024
d303550
Add `.load()` to `_get_dataset_with_source_vars()` to improve perform…
tomvothecoder Sep 9, 2024
b1dfeeb
Clean up run script
tomvothecoder Sep 13, 2024
aad246f
Revert `.load()` in `_get_dataset_with_source_vars()`
tomvothecoder Sep 13, 2024
04f0892
Replace `fastAllGridFT` with `_fft_all_grid`
tomvothecoder Sep 13, 2024
e789222
Code clean up and fix pre-commit issues
tomvothecoder Sep 13, 2024
76ff0d2
Update `fastAllGridFT` to `_fft_all_grid`
tomvothecoder Sep 13, 2024
65a096f
add png regression test script
chengzhuzhang Sep 10, 2024
2ffb6e0
add png regression test script
chengzhuzhang Sep 18, 2024
5818318
fix CI for a missing file
chengzhuzhang Sep 18, 2024
9049725
Remove unused annual_cycle_aerosol diags
tomvothecoder Sep 27, 2024
d8b794a
Remove unused `_select_point()` function
tomvothecoder Sep 27, 2024
fc9a940
Add arm_diags png regression testing
tomvothecoder Sep 27, 2024
54999a7
Update regression testing png notebook
tomvothecoder Sep 27, 2024
420821f
Fix ncycle=1 misaligned dims in `climo_xr.py`
tomvothecoder Sep 27, 2024
640b42a
Address ref FIXME comment
tomvothecoder Sep 30, 2024
0d0671c
Fix `_get_time_slice()` `end_time` format when years <1000
tomvothecoder Sep 30, 2024
311a630
Refactor `arm_diags_plot.py`
tomvothecoder Sep 30, 2024
fb8a320
Update regression testing notebook
tomvothecoder Sep 30, 2024
da6d110
Add logic to exclude last time coordinate for sub-monthly data
tomvothecoder Sep 30, 2024
67de95c
Fix unit tests for submonthly time series data
tomvothecoder Sep 30, 2024
5821a85
Update .get statement for long_name attr when it does not exist
tomvothecoder Sep 30, 2024
c13ad23
Add .get for long_name and other attrs
tomvothecoder Sep 30, 2024
49ee2a5
Apply suggestions from code review
tomvothecoder Sep 30, 2024
8c936be
Fix RegionStats type annotation
tomvothecoder Sep 30, 2024
dd4e7fe
Add `_exclude_sub_monthly_coord_spanning_year` to replicate cdms2 "co…
tomvothecoder Oct 1, 2024
7b53932
Update e3sm_diags/driver/utils/dataset_xr.py
tomvothecoder Oct 1, 2024
858966b
Update e3sm_diags/driver/utils/climo_xr.py
tomvothecoder Oct 1, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add .get for long_name and other attrs
  • Loading branch information
tomvothecoder committed Oct 1, 2024
commit c13ad23b5f5a3eab63082a74dff044411e1f0dba
6 changes: 3 additions & 3 deletions e3sm_diags/driver/arm_diags_driver.py
Original file line number Diff line number Diff line change
Expand Up @@ -144,10 +144,10 @@ def _run_diag_diurnal_cycle(parameter: ARMDiagsParameter) -> ARMDiagsParameter:
_save_metrics_to_json(parameter, metrics_dict)

# Set the plot and viewer output attributes.
parameter.viewer_descr[var] = ds_test[var].long_name
parameter.viewer_descr[var] = ds_test[var].attrs.get("long_name", var)
parameter.test_name_yrs = test_ds.get_name_yrs_attr()
parameter.var_name = ds_test[var].long_name
parameter.var_units = ds_test[var].units
parameter.var_name = ds_test[var].attrs.get("long_name", var)
parameter.var_units = ds_test[var].attrs.get("units", var)

arm_diags_plot._plot_diurnal_cycle(parameter, vars_to_data[season])

Expand Down