Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDAT Migration Phase 1: Replace cdp.cdp_run #641

Merged
merged 2 commits into from
Dec 21, 2022
Merged

CDAT Migration Phase 1: Replace cdp.cdp_run #641

merged 2 commits into from
Dec 21, 2022

Commits on Dec 21, 2022

  1. Remove cdp.cdp_run dependency 

    - Port `serial` and `multiprocess` from `cdp_run`
- Remove logic for distributed because it never actually worked

Refactor `e3sm_diags_driver.py` functions
- Add comments to `main()`
- Move function order based on callstack
- Move `_collapse_results()` call to `_run_serially()` and `run_with_dask_multiprocess()`
- Add docstrings and type annotations
- Rename `parameters` to `parameter_results` in `main()`

Add `pytest` and `pytest-cov`
- Update `test.sh` to use `pytest`
- Add `pytest` config in `setup.cfg`
    @tomvothecoder
    tomvothecoder committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    a0984aa View commit details
    Browse the repository at this point in the history

  2. Refactor _run_with_dask_multiprocessing 

    - Rename to `_run_with_dask`
- Remove `num_workers` arg
    @tomvothecoder
    tomvothecoder committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    94d8b9c View commit details
    Browse the repository at this point in the history