cocoa: fix dragging out of focus window

fffab30 introduced a small regression where the cursor couldn't be unhidden after refocusing. the problem is that no mouseUp event was reported in our events_view. work around this with a separate event monitor. this also fixes another regression when the window is being dragged from the title bar. mpv-player#4174
DonkieJay · Feb 21, 2017 · c824a02 · c824a02
1 parent aeddc49
commit c824a02
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 6 deletions.
diff --git a/osdep/macosx_compat.h b/osdep/macosx_compat.h
@@ -39,6 +39,7 @@ static const NSEventType NSEventTypeKeyUp = NSKeyUp;
 
 static const NSEventMask NSEventMaskKeyDown = NSKeyDownMask;
 static const NSEventMask NSEventMaskKeyUp = NSKeyUpMask;
+static const NSEventMask NSEventMaskLeftMouseUp = NSLeftMouseUpMask;
 
 #if (MAC_OS_X_VERSION_MAX_ALLOWED < MAC_OS_X_VERSION_10_10)
 typedef NSUInteger NSEventModifierFlags;

diff --git a/video/out/cocoa/events_view.m b/video/out/cocoa/events_view.m
@@ -211,7 +211,6 @@ - (void)mouseUp:(NSEvent *)event
 {
     if ([self.adapter mouseEnabled]) {
         [self mouseUpEvent:event];
-        [self.adapter mouseUp];
     } else {
         [super mouseUp:event];
     }

diff --git a/video/out/cocoa_common.m b/video/out/cocoa_common.m
@@ -77,6 +77,7 @@ static CVReturn displayLinkCallback(CVDisplayLinkRef displayLink, const CVTimeSt
     bool cursor_visibility;
     bool cursor_visibility_wanted;
     bool window_is_dragged;
+    id event_monitor_mouseup;
 
     bool embedded; // wether we are embedding in another GUI
 
@@ -352,6 +353,23 @@ static void vo_cocoa_uninit_displaylink(struct vo_cocoa_state *s)
     CVDisplayLinkRelease(s->link);
 }
 
+static void cocoa_add_event_monitor(struct vo *vo)
+{
+    struct vo_cocoa_state *s = vo->cocoa;
+
+    s->event_monitor_mouseup = [NSEvent
+        addLocalMonitorForEventsMatchingMask: NSEventMaskLeftMouseUp
+                                     handler:^NSEvent*(NSEvent* event) {
+            s->window_is_dragged = false;
+            return event;
+        }];
+}
+
+static void cocoa_rm_event_monitor(struct vo *vo)
+{
+    [NSEvent removeMonitor:vo->cocoa->event_monitor_mouseup];
+}
+
 void vo_cocoa_init(struct vo *vo)
 {
     struct vo_cocoa_state *s = talloc_zero(NULL, struct vo_cocoa_state);
@@ -372,6 +390,8 @@ void vo_cocoa_init(struct vo *vo)
     vo_cocoa_init_displaylink(vo);
     cocoa_init_light_sensor(vo);
     cocoa_add_screen_reconfiguration_observer(vo);
+    cocoa_add_event_monitor(vo);
+
     if (!s->embedded) {
         [NSApp setActivationPolicy:NSApplicationActivationPolicyRegular];
         set_application_icon(NSApp);
@@ -426,6 +446,7 @@ void vo_cocoa_uninit(struct vo *vo)
         vo_cocoa_signal_swap(s);
         cocoa_uninit_light_sensor(s);
         cocoa_rm_screen_reconfiguration_observer(vo);
+        cocoa_rm_event_monitor(vo);
 
         [s->nsgl_ctx release];
         CGLReleaseContext(s->cgl_ctx);
@@ -1059,9 +1080,4 @@ - (void)windowWillMove:(NSNotification *)notification
     self.vout->cocoa->window_is_dragged = true;
 }
 
-- (void)mouseUp
-{
-    self.vout->cocoa->window_is_dragged = false;
-}
-
 @end