Skip to content

Commit

Permalink
Debug destroy (steveukx#525)
Browse files Browse the repository at this point in the history
* Update workflows to run CI against `main`
Update `debug` dependency
Remove use of deprecated `debug().destroy()` - Closes steveukx#524

* Changelog
  • Loading branch information
steveukx committed Nov 20, 2020
1 parent 94d0808 commit d15ac3f
Show file tree
Hide file tree
Showing 5 changed files with 27 additions and 12 deletions.
18 changes: 9 additions & 9 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ name: CI

on:
push:
branches: [ master ]
branches: [ main ]
pull_request:
branches: [ master ]
branches: [ main ]

jobs:
build:
Expand All @@ -26,10 +26,10 @@ jobs:
key: ${{ matrix.node-version }}-${{ runner.OS }}-build-${{ hashFiles('package.json') }}
- name: Dependencies
if: steps.cache-modules.outputs.cache-hit != 'true'
run: yarn
- run: echo "::set-env name=GIT_AUTHOR_NAME::Simple Git Tests"
- run: echo "::set-env name=GIT_AUTHOR_EMAIL::[email protected]"
- name: Build
run: yarn build
- name: Test
run: yarn test
env:
GIT_AUTHOR_NAME: "Simple Git Tests"
GIT_AUTHOR_EMAIL: "[email protected]"
run: |
yarn
yarn build
yarn test
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@

# Change History & Release Notes

## 2.23.0 update `debug` dependency & `master` -> `main`

- Upgrade `debug` dependency and remove use of now deprecated `debug().destroy()`
- Renames the default source branch from `master` to `main`

## 2.22.0 add `git.hashObject` interface

- Adds support for `git hash-object FILE` and `git hash-object -w FILE`
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"dependencies": {
"@kwsites/file-exists": "^1.1.1",
"@kwsites/promise-deferred": "^1.1.1",
"debug": "^4.1.1"
"debug": "^4.3.1"
},
"devDependencies": {
"@babel/core": "^7.10.1",
Expand Down
2 changes: 0 additions & 2 deletions src/lib/git-logger.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,10 @@ export function createLogger (label: string, verbose?: string | Debugger, initia
const spawned: OutputLogger[] = [];
const debugDebugger: Maybe<Debugger> = (typeof verbose === 'string') ? infoDebugger.extend(verbose) : verbose;
const key = childLoggerName(filterType(verbose, filterString), debugDebugger, infoDebugger);
const kill = (debugDebugger?.destroy || NOOP).bind(debugDebugger);

return step(initialStep);

function destroy() {
kill();
spawned.forEach(logger => logger.destroy());
spawned.length = 0;
}
Expand Down
12 changes: 12 additions & 0 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2011,6 +2011,13 @@ debug@^4.1.0, debug@^4.1.1:
dependencies:
ms "^2.1.1"

debug@^4.3.1:
version "4.3.1"
resolved "https://registry.yarnpkg.com/debug/-/debug-4.3.1.tgz#f0d229c505e0c6d8c49ac553d1b13dc183f6b2ee"
integrity sha512-doEwdvm4PCeK4K3RQN2ZC2BYUBaxwLARCqZmMjtF8a51J2Rb0xpVloFRnCODwqjpwnAoao4pelN8l3RJdv3gRQ==
dependencies:
ms "2.1.2"

decamelize@^1.2.0:
version "1.2.0"
resolved "https://registry.yarnpkg.com/decamelize/-/decamelize-1.2.0.tgz#f6534d15148269b20352e7bee26f501f9a191290"
Expand Down Expand Up @@ -3471,6 +3478,11 @@ [email protected]:
resolved "https://registry.yarnpkg.com/ms/-/ms-2.0.0.tgz#5608aeadfc00be6c2901df5f9861788de0d597c8"
integrity sha1-VgiurfwAvmwpAd9fmGF4jeDVl8g=

[email protected]:
version "2.1.2"
resolved "https://registry.yarnpkg.com/ms/-/ms-2.1.2.tgz#d09d1f357b443f493382a8eb3ccd183872ae6009"
integrity sha512-sGkPx+VjMtmA6MX27oA4FBFELFCZZ4S4XqeGOXCv68tT+jb3vk/RyaKWP0PTKyWtmLSM0b+adUTEvbs1PEaH2w==

ms@^2.1.1:
version "2.1.1"
resolved "https://registry.yarnpkg.com/ms/-/ms-2.1.1.tgz#30a5864eb3ebb0a66f2ebe6d727af06a09d86e0a"
Expand Down

0 comments on commit d15ac3f

Please sign in to comment.