Updated for new dependency versions #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSpeichert
approved these changes
Apr 5, 2020
|
These changes look good, thanks a lot! |
|
@LolHens I've used your suggestion and Docker image is now automatically pushed to https://github.com/DevelopersPL/godnsagent/packages |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the code to work with newer versions of the referenced dependencies.
It also adds three features:
The first one is from #2 which allows you to disable prefetch completely.
The second one is the option to disable https for the api and only use http.
Thirdly I added the zones-auto-reload parameter to enable automatically reloading the zones file without notifications in a specified interval.
Also the PR adds a Dockerfile which makes it very easy to just register this repository with any account on dockerhub and dockerhub will build an image out of this repository.
I have already done so but it would probably be better if the original author could create an official repository on dockerhub.
https://hub.docker.com/repository/docker/lolhens/godnsagent