Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Mac support and clean up dependencies #530

Merged
merged 12 commits into from
Jun 19, 2024
Merged

Improve Mac support and clean up dependencies #530

merged 12 commits into from
Jun 19, 2024

Conversation

m-reuter
Copy link
Member

On the mac we only have older bash versions. Installing a newer bash 4 or 5 via brew is possible, but sub-scripts still include /bin/bash via the # first line directive (reported here #528 ). Modifying that line could break portability to other OSs (maybe #!/usr/bin/env bash is portable but poses a privilege escalation security threat). Therefore we replace all bash 4.* functionality with alternatives that are supported with older bash 3.1.

  • |&gets replaced with 2>&1 |
  • @Q expansion gets replaced with printf %q(available since bash 3.1)
  • requirememnts.mac.txt gets updated to newer dependency versions (no more torch dev required etc) in accordance to updated requirements.txt. It also now allows version ranges, making it less repeatable, but more flexible.
  • pyproject.toml now includes some missing dependencies and also bumps versions in accordance with requirements.txt
  • INSTALL.md text gets updated accordingly for mac native install (no newer bash needed)
  • deprecated panda delim_whitespace? gets updated to sep='\s+' (this is really independent of the mac version).

Copy link
Member

@dkuegler dkuegler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All else seems fine.

requirements.mac.txt Outdated Show resolved Hide resolved
@m-reuter m-reuter merged commit d4767d9 into dev Jun 19, 2024
2 checks passed
@m-reuter m-reuter deleted the mac branch June 19, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants