Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: --no_fs_t1 lower case #325

Merged
merged 1 commit into from
Jun 1, 2023
Merged

hotfix: --no_fs_t1 lower case #325

merged 1 commit into from
Jun 1, 2023

Conversation

m-reuter
Copy link
Member

@m-reuter m-reuter commented Jun 1, 2023

closes #324

@m-reuter m-reuter merged commit c951b24 into stable Jun 1, 2023
@m-reuter m-reuter deleted the hotfix-nofst1-lowercase branch June 1, 2023 06:46
@LeHenschel
Copy link
Member

So if you want to do the fix this way around (changing it in recon_surf.sh), the documentation needs to be updated as well. Both in recon_surf.sh and run_fastsurfer.sh the flag is described with upper case. Otherwise, it would have been easier to change it in run_fastsurfer.sh because this is the only place where the T was lower case.

@m-reuter
Copy link
Member Author

m-reuter commented Jun 1, 2023

I thought, when we check for parameters, we always convert the input to lower case and then compare the strings in lower case format. That is why I changed it like this.

@LeHenschel
Copy link
Member

Ok, I see. Then it makes sense. I was not aware of the new changes there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no_fs_T1 not passed correctly between run_fastsurfer and recon-surf
2 participants