Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup broken symlinks #51

Merged
merged 1 commit into from
Nov 23, 2020
Merged

Cleanup broken symlinks #51

merged 1 commit into from
Nov 23, 2020

Conversation

martinisoft
Copy link
Contributor

These survived the attempted removal in fb8411b

Without removing these, it creates fun file missing errors when cloning/copying the repo like so:

$ grep -R -a 'discount_code' .
grep: ./store-frontend-instrumented-fixed/store-frontend/app/controllers/.#discount_code.rb: No such file or directory
grep: ./store-frontend-broken-no-instrumentation/store-frontend/app/controllers/.#discount_code.rb: No such file or directory

This must be merged before #49 can be considered

@martinisoft
Cleanup broken symlinks
84aaee3 
These survived the attempted removal in fb8411b

Without removing these, it creates fun file missing errors when
cloning/copying the repo.
@martinisoft martinisoft self-assigned this Nov 23, 2020
@martinisoft martinisoft added the bug Something isn't working label Nov 23, 2020
@burningion burningion merged commit f47ff3d into master Nov 23, 2020
@burningion burningion deleted the aaron.kalin/cleanup_broken_symlinks branch November 23, 2020 16:56
@martinisoft martinisoft mentioned this pull request Apr 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burningion burningion Awaiting requested review from burningion

Assignees

@martinisoft martinisoft

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinisoft @burningion