fix docker-compose files for lms #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested and works locally for the security scenario. Others should be tested. But they have likely been broken for some time in docker-compose. A follow up action should also be to update any of the other files that override the CMD for the storedog containers. |
stanleegoodspeed
approved these changes
Nov 10, 2021
There was a problem hiding this comment.
I was able to successfully spin up these compose files locally, so these changes LGTM.
- deploy/docker-compose/docker-compose-fixed-instrumented-attack.yml
- deploy/docker-compose/docker-compose-fixed-instrumented.yml
- deploy/docker-compose/docker-compose-broken-instrumented.yml
- deploy/docker-compose/docker-compose-broken-no-instrumentation.yml
- deploy/docker-compose/docker-compose-broken-no-apm-instrumentation.yml
FWIW, I'm also able to spin these up using the current main branch. So I'm a little unclear on how to "break" the current version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a problem introduced in 3199fe5 where patches were added in favor of reducing code duplication. The docker-compose files formerly leveraged a shared volume with each code set. Now that the patches are applied to the containers themselves this PR does the following:
Adds an entrypoint outside of the app working directory to
/opt/storedog/Removes volume share from the docker-compose itself
Removes explicit command override in favor of letting the container default to the CMD in the Dockerfile