Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build the ads errors image when fixed changes #147

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

arapulido
Copy link
Collaborator

The ads-error image is just based on a patch for ads-service-fixed, so we need to build it every time ads-service-fixed changes as well, if not we are missing a lot of updates in this image

Copy link
Contributor

@martinisoft martinisoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and a good point. We will want another PR following this one to update the release process to include this updated image in the tagged releases too.

@arapulido arapulido merged commit a15e1c1 into main Jun 16, 2021
@arapulido arapulido deleted the ara.pulido/ads-error-workflow branch June 16, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants