Add ability to submit metrics via named pipes #3230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randomanderson
force-pushed
the
landerson/named-pipe-statsd
branch
from
0731ea7
to
ab3cfb1
Compare
bantonsson
approved these changes
Dec 17, 2021
devinsba
approved these changes
Dec 20, 2021
|
@devinsba It was fairly simple to add Windows to the JMXFetch PR: https://github.com/DataDog/java-dogstatsd-client/pull/169/files#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47 . The work is really getting the build to work on Windows. |
randomanderson
force-pushed
the
landerson/named-pipe-statsd
branch
from
ab3cfb1
to
2181fbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, allows metrics to be submitted via a named pipe. Most of the changes here are plumbing the named pipe config option through to the dogstatsd client builder.
I also added retry logic to the connection because there is often a race between the start of the dogstatsd server and the tracer starting.
This PR relies on DataDog/java-dogstatsd-client#169 being merged and released (does not compile until it is released)
There are no automated tests in this PR because currently neither the build, nor the testsuite can run on Windows. It would be quite a large effort to get the testsuite working on windows.