Rearchitect ScopeEvents to reduce cputime calls #2610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bantonsson
approved these changes
Apr 15, 2021
jbachorik
approved these changes
Apr 15, 2021
tylerbenson
pushed a commit
that referenced
this pull request
Apr 15, 2021
Rearchitect ScopeEvents to reduce cputime calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls to
getCurrentThreadCpuTime()add up especially when there are a lot of scopes created. With this PR, there are at most 2 calls perScopeEventinstead of a call at every pause and resume.The simple case of a scope with two child scopes:
Activate Scope A
Activate Scope B
Finish Scope B
Activate Scope C
Finish Scope C
Finish Scope A
Goes from 10 calls down to 6.