Axis2 + Synapse Instrumentation #2350
Conversation
...mentation/axis-2/src/main/java/datadog/trace/instrumentation/axis2/AxisMessageDecorator.java
Outdated
Show resolved
Hide resolved
...mentation/axis-2/src/main/java/datadog/trace/instrumentation/axis2/AxisMessageDecorator.java
Outdated
Show resolved
Hide resolved
mcculls
force-pushed
the
mcculls/axis2
branch
4 times, most recently
from
9d1b47f
to
01d4621
Compare
mcculls
force-pushed
the
mcculls/axis2
branch
9 times, most recently
from
62b478e
to
8b154e0
Compare
...rumentation/axis-2/src/test/groovy/datadog/trace/instrumentation/axis2/AxisEngineTest.groovy
Outdated
Show resolved
Hide resolved
mcculls
force-pushed
the
mcculls/axis2
branch
from
8b154e0
to
75b5bd2
Compare
mcculls
force-pushed
the
mcculls/axis2
branch
from
75b5bd2
to
76e4e4b
Compare
...tion/axis-2/src/main/java/datadog/trace/instrumentation/axis2/AxisEngineInstrumentation.java
Outdated
Show resolved
Hide resolved
...n/synapse-3/src/main/java/datadog/trace/instrumentation/synapse3/SynapseServerDecorator.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| protected URIDataAdapter url(final SourceRequest request) { | ||
| return new DefaultURIDataAdapter(URI.create(request.getUri())); |
There was a problem hiding this comment.
Ideally there would be some way not to call URI.create
There was a problem hiding this comment.
I agree, especially since we only extract certain elements from the URI - I can look into that in a follow-up PR as that would help a lot of other instrumentations
There was a problem hiding this comment.
Well, that wasn't my point, most instrumentations don't construct the URI, which is why this method now returns URIDataAdapter rather than URI, I was suggesting not to construct the URI here.
There was a problem hiding this comment.
Sure, but some parsing will be needed and I can then re-use the same approach for the instrumentations that also create URIs because they only have an unparsed URI string (such as all the Netty instrumentations and the Finatra instrumentation)
There was a problem hiding this comment.
That sounds excellent - particularly for Netty
mcculls
force-pushed
the
mcculls/axis2
branch
from
1b3579a
to
857ff98
Compare
Adds support for tracing Apache/Axis2 SOAP messages, including across pause+resume where messages may be resumed on another thread. Also adds tracing of message requests coming through Apache/Synapse's "passthru" NHTTP transport. Other transports such as JMS are handled by existing integrations.