Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #483 #484

Merged
merged 5 commits into from
Mar 30, 2023
Merged

fix #483 #484

merged 5 commits into from
Mar 30, 2023

Conversation

STRd6
Copy link
Contributor

@STRd6 STRd6 commented Mar 30, 2023

No description provided.

@STRd6 STRd6 temporarily deployed to build March 30, 2023 02:57 — with GitHub Actions Inactive
@edemaine edemaine linked an issue Mar 30, 2023 that may be closed by this pull request
class doesn't parse as key when in implicit object literal #483
Closed
@STRd6 STRd6 temporarily deployed to build March 30, 2023 03:42 — with GitHub Actions Inactive
@STRd6 STRd6 requested a review from edemaine March 30, 2023 03:44
@STRd6 STRd6 temporarily deployed to build March 30, 2023 03:47 — with GitHub Actions Inactive
edemaine
edemaine approved these changes Mar 30, 2023
View reviewed changes
source/parser.hera Outdated Show resolved Hide resolved
source/parser.hera Outdated
@@ -4650,7 +4650,7 @@ Catch
return { $loc, token: $1 }

Class
"class" NonIdContinue ->
"class" !":" NonIdContinue ->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Should we be consistent about whether colon is excluded from the low-level rule like this, or where it's used (like how you moved Void)?
  2. Any chance it makes sense to put colon exclusion in NonIdContinue? Or would that break other things?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally they would all be higher up (like in the unary ops).

@STRd6 @edemaine
Update source/parser.hera
07d043c 
Co-authored-by: Erik Demaine <[email protected]>
@STRd6 STRd6 temporarily deployed to build March 30, 2023 04:25 — with GitHub Actions Inactive
@STRd6 STRd6 temporarily deployed to build March 30, 2023 04:28 — with GitHub Actions Inactive
@STRd6 STRd6 merged commit 0e4a857 into main Mar 30, 2023
@STRd6 STRd6 deleted the 483 branch March 30, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edemaine edemaine edemaine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

class doesn't parse as key when in implicit object literal
2 participants
@STRd6 @edemaine