Fixes #420 Decorate exported class #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edemaine
reviewed
Mar 2, 2023
source/parser.hera
Outdated
| @@ -5349,6 +5349,9 @@ TypeDeclaration | |||
| ( Export _? )? ( Declare _? ) TypeLexicalDeclaration -> { ts: true, children: $0 } | |||
| ( Export _? )? ( Declare _? )? TypeDeclarationRest -> { ts: true, children: $0 } | |||
|
|
|||
| # NOTE: TS Exported classes can have decorators before export but not after | |||
| Decorators ( Export _? ) !Decorators ClassDeclaration -> { ts: true, children: $0 } | |||
There was a problem hiding this comment.
I don't think this should be ts: true. Exported classes should be in JS code too, just like other decorated classes.
Related, why is this here and not in ExportDeclaration?
Ah, I see, this type of decorating is inconsistent with the TC39 decorator proposal...
|
Could you explain (maybe with a test case) why we need another flag here? Oh, was this a consequence of extending to CallExpression in a previous PR? Kind of surprised any tests passed... I could see forbidding any implicit call with a class expression... But I guess it's nice to preserve it. |
edemaine
approved these changes
Mar 2, 2023
|
Yeah, the idea was to keep allowing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows decorators in TS "before export" and TC39 "after export" positions and doesn't try to do anything smart about it yet.
I added another state flag for when we are inside
Decoratorsto prevent@@decorator class ...from being treated as an implicit call passing a class expression to the decorator function. If someone really wants to do that they'll need to use parentheses and be explicit.