Allow newline before type inside parens #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edemaine
approved these changes
Feb 11, 2023
| @@ -5255,7 +5255,7 @@ TypePrimary | |||
| _? IdentifierName (Dot IdentifierName)* TypeArguments? | |||
| # NOTE: Check FunctionType before parenthesized in order to distinguish between (a: T) => U and | |||
| # A parenthesized inline interface (a: T) ---> ({a: T}) | |||
| __ OpenParen Type __ CloseParen | |||
| __ OpenParen ( Type / ( EOS Type ) ) __ CloseParen | |||
There was a problem hiding this comment.
This could be rewritten as follows:
Suggested change
| __ OpenParen ( Type / ( EOS Type ) ) __ CloseParen | |
| __ OpenParen ( EOS? Type ) __ CloseParen |
Or maybe even simpler:
Suggested change
| __ OpenParen ( Type / ( EOS Type ) ) __ CloseParen | |
| __ OpenParen __ Type __ CloseParen |
I'm a little confused why Type doesn't allow leading __ already. Ah, I see, it's because TypePrimary has lots of _? prefixes but sometimes-not-always a __ prefix. Seems a bit messy, but this should work...
There was a problem hiding this comment.
I want it to check Type first to handle nested implicit interfaces. __ Type would swallow the EOS and prevent Nested from matching.
There was a problem hiding this comment.
Oh, I see. Interesting! Resolved.
There was a problem hiding this comment.
(but maybe worth adding a comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.