Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#156. Improve TS declare lexical bindings #259

Merged
merged 4 commits into from
Jan 21, 2023
Merged

#156. Improve TS declare lexical bindings #259

merged 4 commits into from
Jan 21, 2023

Conversation

STRd6
Copy link
Contributor

@STRd6 STRd6 commented Jan 20, 2023

No description provided.

@STRd6 STRd6 temporarily deployed to build January 20, 2023 16:24 — with GitHub Actions Inactive
edemaine
edemaine approved these changes Jan 20, 2023
View reviewed changes
Copy link
Collaborator

@edemaine edemaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great; a major improvement.

It took me a while to understand the TypeLexicalDeclaration/TypeDeclarationRest dichotomy, so I have some suggestions for comments.

source/parser.hera Show resolved Hide resolved
source/parser.hera Outdated Show resolved Hide resolved
source/parser.hera Show resolved Hide resolved
test/types/type-declaration.civet Show resolved Hide resolved
@STRd6 @edemaine
Update source/parser.hera
9f73a7e 
Co-authored-by: Erik Demaine <[email protected]>
@STRd6 STRd6 temporarily deployed to build January 20, 2023 23:56 — with GitHub Actions Inactive
@STRd6 STRd6 temporarily deployed to build January 21, 2023 00:06 — with GitHub Actions Inactive
@STRd6 STRd6 temporarily deployed to build January 21, 2023 00:16 — with GitHub Actions Inactive
@STRd6 STRd6 merged commit ddc9131 into main Jan 21, 2023
@STRd6 STRd6 deleted the 156 branch January 21, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edemaine edemaine edemaine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@STRd6 @edemaine