Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding subjectAlternativeNames support #23

Merged
merged 2 commits into from
Sep 16, 2022

Conversation

Muffinman
Copy link
Contributor

As discussed in #22, this PR adds subjectAlternativeNames support.

The following is currently untested, but just wanted to check direction before I go any further.

@Daanra
Copy link
Owner

Daanra commented Aug 11, 2022

Thanks for the effort!

I think it can be done without breaking changes by adding the SAN functionality to the PendingCertificate class.

For example:

LetsEncrypt::certificate('mydomain.com')
        ->subjectAlternativeNames(['mydomain2.com'])
        ->create(); 

@Muffinman Muffinman marked this pull request as ready for review September 12, 2022 15:03
@Muffinman
Copy link
Contributor Author

Hi @Daanra,

I had just assumed those create() and createNow() methods on the Facade would have to be updated. If doing as you suggest this makes for a far simpler PR.

@Muffinman Muffinman changed the title [WIP] Adding subjectAlternativeNames support Adding subjectAlternativeNames support Sep 13, 2022
@Daanra Daanra self-assigned this Sep 16, 2022
@Daanra Daanra changed the base branch from master to feat/subject-alternative-names September 16, 2022 10:30
@Daanra
Copy link
Owner

Daanra commented Sep 16, 2022

@Muffinman Thanks, looks great!

@Daanra Daanra merged commit c925b62 into Daanra:feat/subject-alternative-names Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants