Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation of shared layers in MlpExtractor #1252

Merged
merged 7 commits into from
Jan 5, 2023

Conversation

AlexPasqua
Copy link
Contributor

@AlexPasqua AlexPasqua commented Dec 28, 2022

Description

Added deprecation warning in MlpExtractor in case there are shared layers in net_arch, i.e. net_arch starts with an integer

Motivation and Context

closes #1161

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have opened an associated PR on the SB3-Contrib repository (if necessary)
  • I have opened an associated PR on the RL-Zoo3 repository (if necessary)
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)
  • I have checked that the documentation builds using make doc (required)

Note: You can run most of the checks using make commit-checks.

Note: we are using a maximum length of 127 characters per line

@AlexPasqua AlexPasqua changed the title Deprecatedion of shared layers in MlpExtractor Deprecation of shared layers in MlpExtractor Dec 28, 2022
@AlexPasqua AlexPasqua marked this pull request as ready for review December 29, 2022 19:28
@araffin araffin self-requested a review January 3, 2023 13:47
@AlexPasqua
Copy link
Contributor Author

@araffin shall I then do an equivalent PR in SB3-contrib?

@araffin
Copy link
Member

araffin commented Jan 4, 2023

shall I then do an equivalent PR in SB3-contrib?

Yes, please =)

Copy link
Member

@araffin araffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks =)
I will merge once the PR in SB3 contrib and RL Zoo are opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Deprecate shared networks
2 participants