Move transferusers #976
Closed
Move transferusers #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 22, 2024
|
It is not part of the App (which is the laravel app) imo. Actually the transfer users script should ultimately not exist and be a laravel command (app/kernel/commands) |
|
So delete the script and only rely on this? https://market.ctrlpanel.gg/resources/resource/35-transfer-users-from-ptero-to-cpgg/ |
|
Both options are not ideal |
|
I do agree, a laravel command would make the most sense. No clue how to write one tho. |
|
So what happens next? Do i close the PR and trash it? & Remove the Docs PR. |
|
I would not move it. I would keep it as is (a temporary solution) that gets replaced with a laravel command later on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move transferusers file for #952 also Updated docs see: Ctrlpanel-gg/docs#117