Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Docker #946

Merged
merged 78 commits into from
Oct 2, 2024
Merged

Conversation

S0ly
Copy link
Member

@S0ly S0ly commented Apr 30, 2024

I'm currently addressing issue #938, though it's still a work in progress. (do not merge for the moment)

The current code incorporates two Docker configurations: one for development and another for deployment, catering to Unraid users.

I've organized these configurations into two folders:

Development: This folder houses the original Docker setup tailored for development purposes.

Standalone: Here, you'll find a modified Docker setup focused solely on running the CtrlPanel with an integrated Nginx. This streamlined setup requires only an external database and Pterodactyl to function efficiently.

I plan to include comprehensive documentation for the standalone setup to ensure ease of use and understanding.

  • make standalone docker
  • remake development docker
  • add better documentation
  • add GitHub workflow for update automation

known issue :

  • account creation blocked by IP may be bugged because of the docker

@MrWeez
Copy link
Collaborator

MrWeez commented Apr 30, 2024

You can mark the PR as a draft.

@S0ly
Copy link
Member Author

S0ly commented Apr 30, 2024

So Like said in the original PR it might be worth considering issue #944. Although related to documentation, the changes proposed there don't directly impact the Docker configurations. However, as suggested in the issue, cleaning up the documentation and merging the building.md markdown into a readme in the development folder could streamline the user experience. This way, users will have everything conveniently located in one place.

@S0ly S0ly marked this pull request as draft April 30, 2024 12:42
@S0ly
Copy link
Member Author

S0ly commented Apr 30, 2024

I'm not sure that the start and stop Docker scripts in the bin folder are still needed since Docker Compose already does it automatically ?

@1day2die
Copy link
Collaborator

1day2die commented May 3, 2024

I'm not sure that the start and stop Docker scripts in the bin folder are still needed since Docker Compose already does it automatically ?

noone really knows as we never really worked on it anyway

@S0ly
Copy link
Member Author

S0ly commented May 3, 2024

@1day2die so I can delete what I think is not useful anymore and even modify the documentations for dockers ? so that I can make you a working development docker and standalone ?

@S0ly
Copy link
Member Author

S0ly commented May 7, 2024

image

while testing the standalone docker I found that it could be nice to detect that the panel is in a docker and desactivate things like the mysql and git detection :)

@1day2die
Copy link
Collaborator

1day2die commented May 7, 2024

@1day2die so I can delete what I think is not useful anymore and even modify the documentations for dockers ? so that I can make you a working development docker and standalone ?

yes

@S0ly
Copy link
Member Author

S0ly commented May 7, 2024

I think the standalone docker is ready, I just need you @1day2die to test it by going to /docker/standalone and doing docker compose up it should make the docker (it can take up to 10 min its essentially an auto install script in some ways), then you will be able to access it on your http://localhost/install

if yes its that I succeeded and so you can make an official docker image in docker hub https://docs.docker.com/guides/walkthroughs/publish-your-image/, I will then try to publish it to platform like unraid
and I will also update the main readme documentation for it but I think I will need another PR for that

@S0ly S0ly self-assigned this May 14, 2024
@S0ly S0ly changed the title Standalone Docker and more refactor: Docker Jun 4, 2024
@S0ly S0ly marked this pull request as ready for review June 9, 2024 15:07
@S0ly
Copy link
Member Author

S0ly commented Jun 9, 2024

The docker is finished, documentation could be upgraded but will be done in the futur
it needs testing it currently works but need testing for wen 0.10 will be finished to be sure everything is working

[Bug] ControlPanel leftovers changed to CtrlPanel
@S0ly
Copy link
Member Author

S0ly commented Jul 24, 2024

@IceToast can you check and merge it please ? some documentation is not done and testing is not done too but for doc there is #969 and for test #928

this PR is just waiting here :)

@S0ly
Copy link
Member Author

S0ly commented Jul 24, 2024

I mean... its like 4 month that we are running it in a docker on our side but it have not been tested by many people only us and james

@IceToast IceToast merged commit 0b99933 into Ctrlpanel-gg:development Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Adding a new feature, or substantial improvements on existing functionality High Priority Critical. Act quickly for resolution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] make an easily deployable docker
5 participants