Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info label to homepage detailing limits of image upload #509

Merged
merged 3 commits into from
Nov 5, 2022

Conversation

Coteh
Copy link
Owner

@Coteh Coteh commented Nov 4, 2022

Other Changes:

  • Improve homepage layout, especially for mobile
  • Move logo to middle of page in homepage, moves back up to the top left when image selected
  • Change CSS selectors for some elements to use class selector instead of id selector
  • Add cypress/ folder to nodemon.json so that server doesn't reload when cypress test file is updated
  • Update copyright
  • Add file size limit to image too large error message

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #509 (8be448e) into master (e773f11) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #509      +/-   ##
==========================================
+ Coverage   82.25%   82.37%   +0.11%     
==========================================
  Files          30       31       +1     
  Lines        1178     1186       +8     
==========================================
+ Hits          969      977       +8     
  Misses        209      209              
Impacted Files Coverage Δ
lib/consts.js 100.00% <100.00%> (ø)
lib/route/index.js 100.00% <100.00%> (ø)
lib/route/upload/index.js 95.23% <100.00%> (+0.11%) ⬆️
lib/util.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Other Changes:
- Improve homepage layout, especially for mobile
- Move logo to middle of page in homepage, moves back up to the top left when image selected
- Change CSS selectors for some elements to use class selector instead of id selector
- Add cypress/ folder to nodemon.json so that server doesn't reload when cypress test file is updated
- Update copyright
- Add file size limit to image too large error message
views/index.ejs Show resolved Hide resolved
… invalid params are passed

Will make it easier and less error-prone to conditionally render the expire time in the homepage
@Coteh Coteh merged commit 3ba5c86 into master Nov 5, 2022
@Coteh Coteh deleted the site-updates branch November 5, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant