Add image thumbnails to user comments section #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other changes: - Change all functions + url variable in database-ops to be const - Extract performUserLogin from change password integ test so that it can be used in user comments integ test as well - Alter both image and user comments HTML slightly so that properties are double quoted rather than single quoted - Add Content-Type header to user comments response so that JSON user comments response has JSON Content-Type and thus can be parsed by superagent in integ test
Codecov Report
@@ Coverage Diff @@
## development #298 +/- ##
===============================================
+ Coverage 55.83% 64.40% +8.57%
===============================================
Files 15 15
Lines 1166 1194 +28
===============================================
+ Hits 651 769 +118
+ Misses 515 425 -90
Continue to review full report at Codecov.
|
…trieving image attribs
…r handler instead - Add errorID to error page. It will be emitted to the page under an "Error Code" label if it exists. - Add integ test for verifying posted timestamp within user comment HTML - Fix copyright HTML encoding in footer
Coteh
commented
Aug 22, 2021
…simpleimage into image-thumbnails-comments
…st, as the image link is what user expects in the HTML rather than solely the ID. Also change wording of the tests slightly.
Coteh
commented
Aug 25, 2021
Coteh
commented
Aug 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13.
Other changes: