Add placeholder image that is displayed when direct link is used for image that does not exist #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…image that does not exist I started working on this for #13, to provide a placeholder image thumbnail in comments section in instances where user commented on deleted image. Then I split this off due to scope, as well as the fact that this would be a good feature to have in not just comments section, but also for direct link accesses too. It seems like imgur takes this approach as well, and that's what I based my implementation off of. Other Changes: - Created integration test utils, which contains just `addImagesForUser` right now. Modified User Images integ test to use this util function as well and ensured those tests still pass. - Added 500 status code error response if DB encountered error while finding image via direct link, an error response would be returned in place of the placeholder image in this case
- Also fix mistake in route.js where I limited the scope for image does not exist variable after adding try-catch scope (I added the try-catch scope so it reports a better error message if that particular image couldn't be loaded)
Codecov Report
@@ Coverage Diff @@
## development #290 +/- ##
===============================================
+ Coverage 53.91% 56.00% +2.08%
===============================================
Files 15 15
Lines 1137 1150 +13
===============================================
+ Hits 613 644 +31
+ Misses 524 506 -18
Continue to review full report at Codecov.
|
Coteh
commented
Aug 3, 2021
Coteh
commented
Aug 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started working on this for #13, to provide a placeholder image thumbnail in comments section in instances where user commented on deleted image. Then I split this off due to scope, as well as the fact that this would be a good feature to have in not just comments section, but also for direct link accesses too. It seems like imgur takes this approach as well, and that's what I based my implementation off of.
Other Changes:
addImagesForUserright now. Modified User Images integ test to use this util function as well and ensured those tests still pass.