Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock dropdown menu to right #263

Merged
merged 4 commits into from
Jun 20, 2021
Merged

Conversation

mayankbucha
Copy link
Contributor

PR for #117. Please review

mayankbucha and others added 3 commits June 15, 2021 22:48
Added username limit to 24 by default. Can be set dynamically through env variable as well using "MAX_USERNAME_LENGTH" variable
Uodated username as per changes

Co-authored-by: James Cote <[email protected]>
Locked dropdown menu to right side
@mayankbucha
Copy link
Contributor Author

Hi @Coteh . I have closed the previous PR and created this new PR from forked repo. In the current PR there was a merging issue as it was not updated to latest commits. So, I have updated forked branch after creating this PR.

@Coteh
Copy link
Owner

Coteh commented Jun 20, 2021

The change itself looks good to me!

I'll take it from here, thanks! I guess for next time make sure the forked development is current with the upstream one.

@Coteh Coteh merged commit caec0af into Coteh:development Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants