Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: animation not trigger for large elements on screen #2027

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

HardeepAsrani
Copy link
Member

Closes #2005.

Summary

It fixes an issue when animation isn't triggered for large elements that are in the viewport with their top and bottom being outside the viewport.

Screenshots


Test instructions

  • Create a page and add the whole content in a group block
  • Add a loading animation to the group block (Fade in for example)
  • Scroll to the middle of the page and reload
  • Make sure it animated

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@HardeepAsrani HardeepAsrani added the pr-checklist-skip Allow this Pull Request to skip checklist. label Dec 20, 2023
@pirate-bot pirate-bot added pr-checklist-complete The Pull Request checklist is complete. (automatic label) labels Dec 20, 2023
@pirate-bot
Copy link
Contributor

Bundle Size Diff

Package Old Size New Size Diff
Animations 284.71 KB 284.72 KB 12 B (0.00%)
Blocks 1.5 MB 1.5 MB 0 B (0.00%)
CSS 91.71 KB 91.71 KB 0 B (0.00%)
Dashboard 349.13 KB 349.13 KB 0 B (0.00%)
Onboarding 152.44 KB 152.44 KB 0 B (0.00%)
Export Import 89.53 KB 89.53 KB 0 B (0.00%)
Pro 354 KB 354 KB 0 B (0.00%)

@pirate-bot
Copy link
Contributor

Plugin build for d3fec2c is ready 🛎️!

@pirate-bot
Copy link
Contributor

E2E Tests

Playwright Test Status:

Performance Results serverResponse: 188.8, firstPaint: 553.15, domContentLoaded: 1632.75, loaded: 1634.65, firstContentfulPaint: 9148.8, firstBlock: 11175.65, type: 49.75, minType: 38.76, maxType: 122.16, typeContainer: 13.49, minTypeContainer: 11.18, maxTypeContainer: 16.85, focus: 58.15, minFocus: 49.22, maxFocus: 72.39, inserterOpen: 25.42, minInserterOpen: 21.51, maxInserterOpen: 29.7, inserterSearch: 7.59, minInserterSearch: 7.25, maxInserterSearch: 8.28, inserterHover: 35.69, minInserterHover: 32.57, maxInserterHover: 37.16, listViewOpen: 147.26, minListViewOpen: 135.08, maxListViewOpen: 170.75

@HardeepAsrani HardeepAsrani merged commit 79b737d into development Dec 26, 2023
14 checks passed
@HardeepAsrani HardeepAsrani deleted the fix/issue-2005 branch December 26, 2023 05:45
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.6.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group block animation isn't triggered when page is already scrolled
3 participants